Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation added to data-dictionary settings page #3981

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Jun 23, 2023

Validation added to data-dictionary settings page to check for existing data dictionary.

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

  • log in as an admin
  • create a data dictionary at /node/add/data?schema=data-dictionary
  • remember the identification you used on the data dictionary page
  • navigate to the DKAN > Data-dictionary settings page
  • enter an invalid ID and click save
  • confirm you get an error message
  • enter a valid ID from step 2 and click save
  • confirm you get a success message

@kaise-lafrai kaise-lafrai force-pushed the data-dictionary-settings-validation branch from c851658 to 5401be5 Compare June 23, 2023 18:13
@kaise-lafrai kaise-lafrai self-assigned this Jun 23, 2023
@janette janette merged commit 119413d into 2.x Jun 26, 2023
@janette janette deleted the data-dictionary-settings-validation branch June 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants