Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4075: Catch Guzzle Exception to avoid breaking harvest #4076

Merged

Conversation

stefan-korn
Copy link
Contributor

fixes #4075

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

@janette
Copy link
Member

janette commented Dec 6, 2023

@stefan-korn thanks for bringing up this issue. We will want to check access to the URL before we get to the check mimetype step. And if a URL is not accessible, send a warning message to the user. So once we locate the best spot for that check (filefetcher, harvest json source validation, etc.) then we can re-work the code and tests, and merge a fix.

@paul-m paul-m changed the base branch from 2.x to remote-type-try-catch December 19, 2023 22:25
@paul-m paul-m merged commit 71ed465 into GetDKAN:remote-type-try-catch Dec 19, 2023
4 of 11 checks passed
@paul-m
Copy link
Contributor

paul-m commented Dec 19, 2023

Merging into a feature branch to expedite working on this.

Thanks @stefan-korn !

@paul-m
Copy link
Contributor

paul-m commented Dec 19, 2023

Work continues: #4084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch Guzzle Exception to avoid breaking harvest
3 participants