Fix JsonPath error on dkan:datastore:drop-all #4098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RootedJsonData
query was somehow wrong in this instance. Fixing that is not so hard.Using the sample content, we also encounter the "Market Value Analysis - Urban Redevelopment Authority" dataset, which does not have distributions that can be imported into the database... Since drop-all now works, it tries to drop non-existent datastores, which halts all progress.
So now
dkan:datastore:drop
(notdrop-all
) will catch these exceptions and report them as warnings.Here's your set of QA commands:
This should all happen without error, but with warnings for three of the datasets: