Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10.2 compatibility additions, exclude PHP 7 & Drupal 9 from testing matrix #4099

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented Jan 19, 2024

Quick note that I'm using str_contains() so this won't be PHP 7.4 compatible.

Includes:

  • Adjusts the DB driver check to be compatible with 10.2

  • Removes PHP 7.4 and Drupal 9.x from the test matrix.

  • Drupal 10 requires at least PHP 8.1 so dropping Drupal 9.x means dropping PHP < 8.1

  • Adds Drupal 10.2 to test matrix with PHP 8.1 and PHP 8.2 (Currently expected to fail PHP 8.2 tests right now)

  • Test coverage exists

  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

@jastraat jastraat requested a review from dafeder January 19, 2024 15:55
@jastraat jastraat changed the title Adjust DB driver check to be Drupal 10.2 compatible Drupal 10.2 compatibility additions Jan 19, 2024
Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-m paul-m changed the title Drupal 10.2 compatibility additions Drupal 10.2 compatibility additions, exclude PHP 7 & Drupal 9 from testing matrix Feb 14, 2024
@paul-m paul-m merged commit 88e03a9 into 2.x Feb 14, 2024
10 checks passed
@paul-m paul-m deleted the drupal_10_2 branch February 14, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants