Use logger channel service rather than factory #4148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the following services to use a logger channel service instead of using a logger factory service to make its own channel:
dkan.datastore.event_subscriber
json_form.builder
json_form.schema_ui_handler
datastore.reimport.commands
We also discover that some plugins generate their own logger channel objects rather than injecting existing ones.
ImportQueueWorker
LocalizeQueueWorker
PostImportResourceProcessor
HideCurrentRevisionAction
In addition, analysis reveals that
dkan.metastore.event_subscriber
doesn't actually use a logger at all, so we remove that dependency from the service declaration.Modify tests to pass.
Minor CS changes.