Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger channel service rather than factory #4148

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Mar 19, 2024

Modifies the following services to use a logger channel service instead of using a logger factory service to make its own channel:

  • dkan.datastore.event_subscriber
  • json_form.builder
  • json_form.schema_ui_handler
  • datastore.reimport.commands

We also discover that some plugins generate their own logger channel objects rather than injecting existing ones.

  • ImportQueueWorker
  • LocalizeQueueWorker
  • PostImportResourceProcessor
  • HideCurrentRevisionAction

In addition, analysis reveals that dkan.metastore.event_subscriber doesn't actually use a logger at all, so we remove that dependency from the service declaration.

Modify tests to pass.

Minor CS changes.

@paul-m paul-m marked this pull request as ready for review March 19, 2024 20:58
@paul-m paul-m changed the title Use logger channel rather than factory Use logger channel service rather than factory Mar 25, 2024
@janette janette merged commit 6c42374 into 2.x Mar 28, 2024
10 checks passed
@janette janette deleted the 19414-logger-services branch March 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants