Show 100% when import done in info/dashboard. #4181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the output from dataset-info, and by extension in the datastore import dashboard, we have a longstanding issue where when using the mysql import module, the percent done stays at zero (0) even though the import process has finished. This is because the mysql importer performs the entire import at once and provides no feedback on amount complete. It was, in hindsight, not such a good idea to assume any job like this would provide "bites processed" information and build the whole dataset info gathering workflow around that assumption.
While the dataset info and datastore dashboard are probably both due for an overhaul, for now we just want coherent information provided to the user. We had two options:
Since the percent done is still useful for people using the CSV parser, and the status value seems to be more reliable than the bytes processed value, I went with #2. This is definitely to be considered a stopgap.
QA Steps