#4190: Search API integration - Property label and description

[stefan-korn]

fixes #4190

[stefan-korn]

One remark: I am not sure if the code would ever get here: https://github.com/GetDKAN/dkan/blob/2.x/modules/metastore/modules/metastore_search/src/ComplexData/Dataset.php#L77
With default DKAN schema it does not get there I suppose, if it would get there there might be a problem with this MR.

[dafeder]

One remark: I am not sure if the code would ever get here: https://github.com/GetDKAN/dkan/blob/2.x/modules/metastore/modules/metastore_search/src/ComplexData/Dataset.php#L77 With default DKAN schema it does not get there I suppose, if it would get there there might be a problem with this MR.

@stefan-korn yeah tbh I understand that final else looking at it. There are no other types than object or array that make sense here, the conditional should either not be there or throw an exception.

[dafeder]

Looks good @stefan-korn! What an improvement.

I think I'll add some test coverage for this and update the default search config in another PR but IMO this can be merged as is since technically the code is "covered" by a test just not by any specific assertions.