feat: Upgrade to Node 18 [Feature Branch][JOB-62820] #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darryltec
commented
Mar 20, 2023
.circleci/config.yml
Outdated
| @@ -44,7 +44,7 @@ references: | |||
| npm_install: &npm_install | |||
| run: | |||
| name: Install Dependencies | |||
| command: export IGNORE_OPTIONAL_DEPENDENCIES=true; npm ci --no-optional | |||
| command: export IGNORE_OPTIONAL_DEPENDENCIES=true; npm ci --no-optional --legacy-peer-deps | |||
There was a problem hiding this comment.
Temporary, just to get us past some hurdles. Delete before merging!
darryltec
force-pushed
the
upgrade-to-node-18
branch
from
3b756f8
to
bd56cf5
Compare
Deploying with
|
| Latest commit: |
ae7f9a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd56d4ff.atlantis.pages.dev |
| Branch Preview URL: | https://upgrade-to-node-18.atlantis.pages.dev |
darryltec
force-pushed
the
upgrade-to-node-18
branch
from
bd56cf5
to
eb99b40
Compare
* build: use NPM workspace instead of Lerna * fix: workaround npm's lack of topological oder Basically, npm would run `prepare` on each packages in alphabetical order but components need design to be built first. This works around that limitation by firing the scripts manually through `npm run [script] -w` which respects the order under `workspaces` npm/rfcs#548 * fix: reorder scripts for my own sanity * build: update circle to not look for lock files * build: use node 18 image on circle ci * fix: js and css linters * build: use -omit=optional * fix: update time test work on node 18 * fix: don't update snaps * fix: update some snaps * build: make storybook run on node 18 Thanks @rodrigoeidelvein for the workaround! * fix: reinstall ts-node * chore: use lerna recommended setting for symlink * fix: refix storybook by using js file * fix: match * on preventManualRelease check
* Update versions in readme * Update engines in package.json
* Trying build * Correcting variables * Removed resource class Co-authored-by: Darryl Tec <darryl.t@getjobber.com> --------- Co-authored-by: Kingston Fung <kingstonfung@gmail.com> Co-authored-by: Darryl Tec <darryl.t@getjobber.com>
taylorvnoj
approved these changes
Mar 24, 2023
🚀
|
Sorry those conflicts are because of me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Node 14 will not be supported past April 30th so we need to get ahead and upgrade to Node 18.
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
In Atlantis we use Github's built in pull request reviews.