docs: Node 18 update readme #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to node-18-update-readme
Deploying with
|
| Latest commit: |
3c94520
|
| Status: | 🚫 Build failed. |
darryltec
added a commit
that referenced
this pull request
Mar 24, 2023
* build: update nvmrc to use 18 * build: repackage package locks * build: temporarily set legacy-peer-deps to true * build: Use NPM Workspace instead of Lerna to bootstrap (#1142) * build: use NPM workspace instead of Lerna * fix: workaround npm's lack of topological oder Basically, npm would run `prepare` on each packages in alphabetical order but components need design to be built first. This works around that limitation by firing the scripts manually through `npm run [script] -w` which respects the order under `workspaces` npm/rfcs#548 * fix: reorder scripts for my own sanity * build: update circle to not look for lock files * build: use node 18 image on circle ci * fix: js and css linters * build: use -omit=optional * fix: update time test work on node 18 * fix: don't update snaps * fix: update some snaps * build: make storybook run on node 18 Thanks @rodrigoeidelvein for the workaround! * fix: reinstall ts-node * chore: use lerna recommended setting for symlink * fix: refix storybook by using js file * fix: match * on preventManualRelease check * docs: Node 18 update readme (#1149) * Update versions in readme * Update engines in package.json * fix: reset package-lock * chore: strict engine and package lock * docs: Fix cloudflare Pages deploy (#1150) * Trying build * Correcting variables * Removed resource class Co-authored-by: Darryl Tec <darryl.t@getjobber.com> --------- Co-authored-by: Kingston Fung <kingstonfung@gmail.com> Co-authored-by: Darryl Tec <darryl.t@getjobber.com> * fix: update package-lock.json --------- Co-authored-by: Michael Paradis <michael.p@getjobber.com> Co-authored-by: Kingston Fung <kingstonfung@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
In Atlantis we use Github's built in pull request reviews.