This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Allow local assignment in partials #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDeighton
commented
Oct 10, 2020
| @@ -8,11 +8,16 @@ module Partials | |||
| # :prawn_object - The object to use for the pdf object in the partial. | |||
| # Defaults to the pdf document, but can take a paramenter to render within a prawn object. This | |||
| # is good for items like tables, text_blocks, etc. | |||
| def partial!(partial_name, prawn_object = pdf) | |||
| def partial!(partial_name, prawn_object = pdf, locals: {}) | |||
There was a problem hiding this comment.
Not sure which ruby versions you want to maintain support for, so this might need to change away from kwarg syntax
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the middle of upgrading a rails 3 app that uses the original version of this gem. In that version there was support for partial rendering with locals, pretty much in line with standard rails view templates. If you wouldn't mind taking a look across this it could save me a big re-write