Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema type optional #138

Closed
fizruk opened this issue Feb 21, 2018 · 1 comment · Fixed by #164
Closed

Make schema type optional #138

fizruk opened this issue Feb 21, 2018 · 1 comment · Fixed by #164

Comments

@fizruk
Copy link
Member

@fizruk fizruk commented Feb 21, 2018

@przemoli

This comment has been minimized.

Copy link

@przemoli przemoli commented Mar 9, 2018

To clarify. If no type is provided, it should be infered based on other properties in definition?
https://github.com/json-schema-faker/json-schema-faker#inferred-types

swamp-agr pushed a commit that referenced this issue Aug 22, 2018
Andrey Prokopenko
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
swamp-agr pushed a commit that referenced this issue Aug 22, 2018
Andrey Prokopenko
`Just _` and `Nothing` cases wrapped properly
@phadej phadej closed this in #164 Apr 25, 2019
phadej added a commit that referenced this issue Apr 25, 2019
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej added a commit that referenced this issue May 17, 2019
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej added a commit that referenced this issue May 17, 2019
Fix #138 schema type becomes optional: rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.