Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema type optional #138

Closed
fizruk opened this issue Feb 21, 2018 · 1 comment · Fixed by #164
Closed

Make schema type optional #138

fizruk opened this issue Feb 21, 2018 · 1 comment · Fixed by #164
Labels
good first issue

Comments

@fizruk
Copy link
Member

fizruk commented Feb 21, 2018

See #131 (comment).
@fizruk fizruk mentioned this issue Feb 22, 2018
Open
@przemoli
Copy link

przemoli commented Mar 9, 2018

To clarify. If no type is provided, it should be infered based on other properties in definition?
https://github.com/json-schema-faker/json-schema-faker#inferred-types

swamp-agr pushed a commit that referenced this issue Aug 22, 2018
Fix #138 schema type becomes optional
6f10ca0 
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
swamp-agr pushed a commit that referenced this issue Aug 22, 2018
Fix doctests for #138
61e004f 
`Just _` and `Nothing` cases wrapped properly
@fizruk fizruk mentioned this issue Aug 23, 2018
Merged
phadej pushed a commit that referenced this issue Apr 25, 2019
@phadej
Fix #138 schema type becomes optional
f43c44e 
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej pushed a commit that referenced this issue May 17, 2019
@phadej
Fix #138 schema type becomes optional
0ccfe21 
According to OpenAPI as it mentioned in #131, "type" might not be specified. It is implemented currently in Kubernetes. Thus, interface is changing with this fix. CHANGELOG should be also updated.
phadej added a commit that referenced this issue May 17, 2019
@phadej
Merge pull request #187 from GetShopTV/schema-fixes-2
82b75a4 
Fix #138 schema type becomes optional: rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow omitting type and infer it when validating GetShopTV/swagger2
2 participants
@fizruk @przemoli