Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC-8.2 #108

Merged
merged 7 commits into from
Jul 14, 2017
Merged

Support GHC-8.2 #108

merged 7 commits into from
Jul 14, 2017

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 28, 2017

No description provided.

@phadej
Copy link
Collaborator Author

phadej commented Jun 29, 2017

Ping @fizruk, are you ok with going with cabal-doctest for doctests?

@fizruk
Copy link
Member

fizruk commented Jun 30, 2017

@phadej anything to make it work :)

@phadej
Copy link
Collaborator Author

phadej commented Jul 7, 2017

@fizruk, could you recheck. I can then make the release.

@phadej
Copy link
Collaborator Author

phadej commented Jul 13, 2017

ping @fizruk

Copy link
Member

@fizruk fizruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, feel free to merge! :)

swagger2.cabal Outdated
test-suite doctest
build-depends: base, doctest, Glob
test-suite doctests
build-depends: base, doctest, Glob, QuickCheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuickCheck?

Copy link
Collaborator Author

@phadej phadej Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have one prop>, it requires QuickCheck then.

This is a little hack, actually we don't need QuickCheck to build doctests.hs; but these dependencies are solved by Cabal, so we can pass them as --package-id=... to doctests executable, so doctest can use / import QuickCheck modules (done by cabal-doctests).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this comment to the file then? Or a link to this conversation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add an entry to cabal-doctest FAQ/Notes and add a link here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a PR. ulidtko/cabal-doctest#16 and added a link to where it will land.

@phadej phadej merged commit 3e81ba4 into GetShopTV:master Jul 14, 2017
@phadej phadej deleted the ghc-8.2 branch July 14, 2017 17:47
@phadej
Copy link
Collaborator Author

phadej commented Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants