-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quickcheck note #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some minor English grammar issues, LGTM.
README.md
Outdated
* `extensions:` field isn't supported. Upgrade your `.cabal` file to use at least | ||
`cabal-version: >= 1.10` and use `default-extensions` or `other-extensions`. | ||
|
||
* If you use QuickCheck properties (`prop>`) in the doctests, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/the doctests/your doctests/g
README.md
Outdated
This is a little HACK: These dependencies aren't needed to build the | ||
`doctests` test-suite executable. However, as we let `Cabal` resolve | ||
dependencies, we can pass the resolved (and installed!) package identifiers to | ||
to the `doctest` command. This way, the `QuickCheck` and `template-haskell` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/the `QuickCheck` and `template-haskell`/`QuickCheck` and `template-haskell`/g
README.md
Outdated
`doctests` test-suite executable. However, as we let `Cabal` resolve | ||
dependencies, we can pass the resolved (and installed!) package identifiers to | ||
to the `doctest` command. This way, the `QuickCheck` and `template-haskell` | ||
are available to the `doctest`, otherwise you'll get errors like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/the `doctest`/`doctest`/g
@RyanGlScott does this note make sense to you?