-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for optics #200
Conversation
It doesn't pick, because Anyway, https://hackage.haskell.org/package/insert-ordered-containers-0.2.3 is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump base >=4.9
, so it's not forgotten.
Ok, I pushed the changes and it's green now 👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fizruk what you think?
For the record, I'm working on a code base that currently uses |
I improved haddock documentation and added doctests. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If nobody requests any more changes, I will merge this on ~2019-11-08.
Trivial conflict, I've resolved it locally and will try to push to master once the tests have passed. |
hum...
my stack.yaml:
i guess i better don't push... sorry @arybczak, could you take another look? |
lts-14.3 has insert-ordered-containers-0.2.2, this PR needs 0.2.3 (as is in .cabal file). Does stack override bound checks from the cabal file? |
oops, yes, the way i configured it. it seems (disclaimer: not a proud stack user, just didn't have a lot of time, and couldn't think of a quicker way to test it.) |
yes, with the extra stack.yaml tweak the test suite passes. i'll merge this to master manually soon! |
Yes, that seems to be the case: commercialhaskell/stack#4495 (comment) I updated the branch, I think you can now merge via github 👍 |
Thanks! |
PR adds support for using
optics
library instead oflens
as an alternative. There are no name clashes becauseoptics
supports lenses/prisms as labels.cc @phadej
EDIT: Travis doesn't pick up
insert-ordered-containers
from thecabal.project
file 🤔