Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade go and Redigo version #4

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

agniBit
Copy link

@agniBit agniBit commented Feb 21, 2023

No description provided.

@Chhekur
Copy link

Chhekur commented Feb 22, 2023

let's remove the vendor changes.
and can we check to go and redigo version upgrade doesn't impact the code?
can we avoid upgrading go version, upgrading also shouldn't make any impact since it's backward compatible, just being skeptical because we don't have full context on the gocraft codebase.

@agniBit
Copy link
Author

agniBit commented Feb 24, 2023

let's remove the vendor changes.
and can we check to go and redigo version upgrade doesn't impact the code?
can we avoid upgrading go version, upgrading also shouldn't make any impact since it's backward compatible, just being skeptical because we don't have full context on the gocraft codebase.

  • removed vendor files ✅
  • we need to go version go-1.17 or above for the Redigo version upgrade, Redigo has only support for Go@1.7+
  • we'll test changes in BillBox stag with some dummy events as well just to confirm everything working as expected, I'll release a dev version for the testing.

Copy link

@Chhekur Chhekur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
just test things thoroughly before releasing to PROD.

@agniBit agniBit merged commit cc710c8 into master Mar 2, 2023
Comment on lines +29 to +30
github.com/gomodule/redigo v1.8.9 h1:Sl3u+2BI/kk+VEatbj0scLdrFhjPmbxOc1myhDP41ws=
github.com/gomodule/redigo v1.8.9/go.mod h1:7ArFNvsTjH8GMMzB4uy1snslv2BwmginuMs06a1uzZE=

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended? reducing the version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants