fix: make message actions keyboard accessible #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
requested review from
szuperaz,
MartinCupela,
oliverlaz and
arnautov-anton
MartinCupela
approved these changes
Feb 16, 2024
|
🎉 This PR is included in version 4.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently message actions are only displayed on hover, and are not accessible from keyboard. This PR makes message actions more accessible.
🛠 Implementation details
This PR includes a slightly scary change to the
button-resetmixin. Previously it removed outline. However, having outline for focused items is important for accessibility, so now outline is not removed.🎨 UI Changes
Screen.Recording.2024-02-14.at.12.34.15.mov