Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix videoCall asset not available. #1587

Merged
merged 10 commits into from
Jun 7, 2023

Conversation

rlee1990
Copy link
Contributor

@rlee1990 rlee1990 commented Jun 5, 2023

Fixes: #1427

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@rlee1990 rlee1990 changed the title Update for Jiffy & a Fix for #1427 fix(ui) Update for Jiffy & a Fix for #1427 Jun 5, 2023
@xsahil03x
Copy link
Contributor

Hey @rlee1990, can you remove the changes done for jiffy? I already have a PR opened for that. This PR can contain the changes required to fix your issue.
#1580

@rlee1990
Copy link
Contributor Author

rlee1990 commented Jun 5, 2023

@xsahil03x sorry did not see that one there sure thing. I will make that change now.

@rlee1990 rlee1990 changed the title fix(ui) Update for Jiffy & a Fix for #1427 fix(ui) Fix for #1427 Jun 5, 2023
@rlee1990
Copy link
Contributor Author

rlee1990 commented Jun 5, 2023

@xsahil03x done.

Copy link
Contributor Author

@rlee1990 rlee1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the Jiffy update.

@xsahil03x
Copy link
Contributor

@rlee1990, It still contains changes for jiffy.

Copy link
Contributor Author

@rlee1990 rlee1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all Jiffy changes.

@rlee1990
Copy link
Contributor Author

rlee1990 commented Jun 6, 2023

@xsahil03x Sorry about that. They should all be removed.

@rlee1990 rlee1990 changed the title fix(ui) Fix for #1427 fix(ui): Fix for #1427 Jun 6, 2023
@xsahil03x
Copy link
Contributor

@rlee1990 can you also add a changelog and run flutter format? Need to pass the checks.

@xsahil03x xsahil03x changed the title fix(ui): Fix for #1427 fix(ui): fix videoCall asset not available. Jun 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d18b65) 58.61% compared to head (54aa65a) 58.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1587   +/-   ##
========================================
  Coverage    58.61%   58.61%           
========================================
  Files          290      290           
  Lines        17679    17679           
========================================
  Hits         10362    10362           
  Misses        7317     7317           
Impacted Files Coverage Δ
...hat_flutter/lib/src/localization/translations.dart 90.78% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xsahil03x xsahil03x merged commit 372fa30 into GetStream:develop Jun 7, 2023
@xsahil03x xsahil03x mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable To Load Asset Error
3 participants