fix(ui): remove double focus for tab navigation on message input #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused focus for accessibility
edeetee
changed the title
|
Hi @edeetee , thank you for spotting this. Can you please resolve the conflicts? |
esarbanis
reviewed
Feb 19, 2024
packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart
Outdated
Show resolved
Hide resolved
esarbanis
changed the title
esarbanis
approved these changes
Feb 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
=======================================
Coverage 59.18% 59.18%
=======================================
Files 310 310
Lines 17828 17828
=======================================
Hits 10552 10552
Misses 7276 7276 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused focus for accessibility
Submit a pull request
CLA
Description of the pull request
The focus elements are causing accessibility users to tab twice in order to reach the text. This removes them from the traversal tree. Why are they here anyway? Just to capture keyboard events?