Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main development branch #1789

Merged
merged 16 commits into from
Nov 24, 2023
Merged

Update main development branch #1789

merged 16 commits into from
Nov 24, 2023

Conversation

esarbanis
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

esarbanis and others added 16 commits October 11, 2023 15:05
…customize_message_widget.mdx

Co-authored-by: Deven Joshi <deven9852@gmail.com>
fix(doc): fix broken documentation snippets
* fix video attachment upload

* fix test

* add changelog
Bumps [connectivity_plus](https://github.com/fluttercommunity/plus_plugins/tree/main/packages/connectivity_plus) from 4.0.2 to 5.0.1.
- [Release notes](https://github.com/fluttercommunity/plus_plugins/releases)
- [Commits](https://github.com/fluttercommunity/plus_plugins/commits/connectivity_plus-v5.0.1/packages/connectivity_plus)

---
updated-dependencies:
- dependency-name: connectivity_plus
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
`showReactionPickerTail` property is bind with `showReactionPicker` as it is the only one needed to couple the reaction modal with the tail

Closes #1759
fix(ui): deprecate exposed `showReactionPickerTail` in `MessageWidget`
fix(doc): update the use of GoRouter in the guides
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3195041) 58.30% compared to head (cf7ee49) 58.82%.

Files Patch % Lines
...flutter/lib/src/message_widget/message_widget.dart 33.33% 2 Missing ⚠️
packages/stream_chat/lib/src/client/client.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
+ Coverage   58.30%   58.82%   +0.52%     
==========================================
  Files         292      292              
  Lines       18010    18010              
==========================================
+ Hits        10500    10594      +94     
+ Misses       7510     7416      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98 deven98 merged commit 11223e6 into master Nov 24, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants