Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): quoted message padding #1868

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

AndreHaueisen
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

StreamQuotedMessageWidget had no bottom padding, making quoted messages look weird.
I removed line 1209 so that the default padding of 8 to all sides can take affect

Before

Simulator Screenshot - iPhone SE (3rd generation) - 2024-02-29 at 10 37 55

After

Simulator Screenshot - iPhone SE (3rd generation) - 2024-02-29 at 10 34 07

@AndreHaueisen AndreHaueisen changed the title Fixes quoted message padding fix: quoted message padding Feb 29, 2024
@AndreHaueisen AndreHaueisen changed the title fix: quoted message padding fix(UI): quoted message padding Feb 29, 2024
@AndreHaueisen AndreHaueisen changed the title fix(UI): quoted message padding fix(ui): quoted message padding Feb 29, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.41%. Comparing base (2cf6d7f) to head (7464f17).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files         310      310           
  Lines       17828    17828           
=======================================
  Hits        10592    10592           
  Misses       7236     7236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit d875da8 into GetStream:master Mar 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants