Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined values in query params #1187

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

vishalnarkhede
Copy link
Contributor

@vishalnarkhede vishalnarkhede commented Oct 19, 2023

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

fixes: GetStream/stream-chat-react-native#2257

params with undefined values need to be excluded from param serialization logic, since stream backend doesn't treat undefined same as param not being present.

@github-actions
Copy link
Contributor

Size Change: +304 B (0%)

Total Size: 322 kB

Filename Size Change
dist/browser.es.js 70.4 kB +70 B (0%)
dist/browser.full-bundle.min.js 37.9 kB +7 B (0%)
dist/browser.js 71.4 kB +76 B (0%)
dist/index.es.js 70.4 kB +74 B (0%)
dist/index.js 71.4 kB +77 B (0%)

compressed-size-action

@vishalnarkhede vishalnarkhede merged commit a325737 into master Oct 19, 2023
7 of 8 checks passed
@vishalnarkhede vishalnarkhede deleted the fix/param-serializer branch October 19, 2023 10:31
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
rchl added a commit to rchl/stream-chat-js that referenced this pull request Nov 29, 2023
* master: (44 commits)
  chore: release v8.14.4 (GetStream#1203)
  fix: add default contentType as multipart/form-data in sendFile (GetStream#1202)
  chore: release v8.14.3 (GetStream#1200)
  fix: use postForm instead of post for sending files (GetStream#1199)
  chore: release v8.14.2 (GetStream#1197)
  fix: reload channel state if frozen flag changed (GetStream#1196)
  chore(release): v8.14.1 (GetStream#1195)
  Update user reference in channel read data (GetStream#1194)
  chore(release): v8.14.0 (GetStream#1193)
  feat: axios upgrade to v1 (GetStream#1192)
  Revert "fix: queue channel WS events until the channel is initialized" (GetStream#1189)
  chore(release): v8.13.1 (GetStream#1188)
  fix: undefined values in query params (GetStream#1187)
  chore(release): v8.13.0 (GetStream#1186)
  feat: support for SNS (GetStream#1185)
  chore: release v8.12.4 (GetStream#1184)
  fix: evaluate channel.lastRead when channel is not initialized (GetStream#1183)
  chore(release): v8.12.3 (GetStream#1182)
  fix: queue channel WS events until the channel is initialized (GetStream#1179)
  chore: release v8.12.2 (GetStream#1181)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Thread reply error
3 participants