Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload channel state if frozen flag changed #1196

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

szuperaz
Copy link
Contributor

@szuperaz szuperaz commented Nov 14, 2023

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Problem: when the frozen flag changes on channels, the backend updates the user's capabilities to reflect the channel's frozen state. However, the backend doesn't send the updated own_capabilities via WS (due to performance reasons), so the client has to reload the channel state to update own_capabilities.

To help SDKs detect when a state update is necessary, the channel now emits capabilities.changed event.

Changelog

  • fix: reload channel state if frozen flag changed

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Size Change: +1.08 kB (0%)

Total Size: 327 kB

Filename Size Change
dist/browser.es.js 70.3 kB +234 B (0%)
dist/browser.full-bundle.min.js 43.6 kB +128 B (0%)
dist/browser.js 71.3 kB +240 B (0%)
dist/index.es.js 70.3 kB +236 B (0%)
dist/index.js 71.3 kB +243 B (0%)

compressed-size-action

oliverlaz
oliverlaz previously approved these changes Nov 14, 2023
oliverlaz
oliverlaz previously approved these changes Nov 15, 2023
vishalnarkhede
vishalnarkhede previously approved these changes Nov 16, 2023
src/channel.ts Outdated Show resolved Hide resolved
Co-authored-by: MartinCupela <32706194+MartinCupela@users.noreply.github.com>
@szuperaz szuperaz merged commit c88d941 into master Nov 16, 2023
5 of 6 checks passed
@szuperaz szuperaz deleted the handle-frozen-channel branch November 16, 2023 10:45
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
rchl added a commit to rchl/stream-chat-js that referenced this pull request Nov 29, 2023
* master: (44 commits)
  chore: release v8.14.4 (GetStream#1203)
  fix: add default contentType as multipart/form-data in sendFile (GetStream#1202)
  chore: release v8.14.3 (GetStream#1200)
  fix: use postForm instead of post for sending files (GetStream#1199)
  chore: release v8.14.2 (GetStream#1197)
  fix: reload channel state if frozen flag changed (GetStream#1196)
  chore(release): v8.14.1 (GetStream#1195)
  Update user reference in channel read data (GetStream#1194)
  chore(release): v8.14.0 (GetStream#1193)
  feat: axios upgrade to v1 (GetStream#1192)
  Revert "fix: queue channel WS events until the channel is initialized" (GetStream#1189)
  chore(release): v8.13.1 (GetStream#1188)
  fix: undefined values in query params (GetStream#1187)
  chore(release): v8.13.0 (GetStream#1186)
  feat: support for SNS (GetStream#1185)
  chore: release v8.12.4 (GetStream#1184)
  fix: evaluate channel.lastRead when channel is not initialized (GetStream#1183)
  chore(release): v8.12.3 (GetStream#1182)
  fix: queue channel WS events until the channel is initialized (GetStream#1179)
  chore: release v8.12.2 (GetStream#1181)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants