Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #239 sendFile accepts buffer and File #448

Merged
merged 4 commits into from
Oct 1, 2020
Merged

fix: #239 sendFile accepts buffer and File #448

merged 4 commits into from
Oct 1, 2020

Conversation

mahboubii
Copy link
Contributor

No description provided.

@mahboubii mahboubii mentioned this pull request Sep 30, 2020
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2020 •
edited
Loading

Size Change: +532 B (0%)

Total Size: 194 kB

Filename Size Change
dist/browser.es.js 41.3 kB +120 B (0%)
dist/browser.full-bundle.min.js 27 kB +45 B (0%)
dist/browser.js 41.9 kB +119 B (0%)
dist/index.es.js 41.4 kB +123 B (0%)
dist/index.js 41.9 kB +125 B (0%)

compressed-size-action

@mahboubii mahboubii mentioned this pull request Sep 30, 2020
Closed
jaapbakker88
jaapbakker88 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@jaapbakker88 jaapbakker88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ferhatelmas
ferhatelmas approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahboubii mahboubii merged commit b62aac7 into master Oct 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/file-upload-buffer branch October 1, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@jaapbakker88 jaapbakker88 jaapbakker88 approved these changes

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mahboubii @ferhatelmas @jaapbakker88