Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: file upload allows buffer and streams #389

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

mahboubii
Copy link
Contributor

@github-actions
Copy link
Contributor

Size Change: +131 B (0%)

Total Size: 102 kB

Filename Size Change
dist/js_min/getstream.js 31.6 kB +50 B (0%)
dist/js/getstream.js 70.2 kB +81 B (0%)

compressed-size-action

Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ferhatelmas
Copy link
Contributor

similar to GetStream/stream-chat-js#448

maybe it should live in a common place but it's also very small.

@mahboubii
Copy link
Contributor Author

similar to GetStream/stream-chat-js#448

maybe it should live in a common place but it's also very small.

I thought about it but the overhead is too much for such a small code

@mahboubii mahboubii merged commit d8a5efb into master Oct 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/file-upload-buffer branch October 1, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants