Add remove quoted messages logics #726
Conversation
| UserType | ||
| >, | ||
| ) { | ||
| const parseMessage = ( |
There was a problem hiding this comment.
@vishalnarkhede second time this function is needed (the other one was in the sdk) maybe we can put it on utils or something?
src/channel_state.ts
Outdated
| @@ -437,6 +437,51 @@ export class ChannelState< | |||
| return messageWithReaction; | |||
| } | |||
|
|
|||
| removeQuotedMessages( | |||
There was a problem hiding this comment.
I think should be more like updateQuotedMessages, and it should also be called on message.updated event. Right?
There was a problem hiding this comment.
Or maybe we need another function called updateQuotedMessages, since there some functionality specific to removing/cleaning quoted message in this function.
There was a problem hiding this comment.
Also can you add unit test for this function?
There was a problem hiding this comment.
yeah tbh this function could be used for updating as well but the main problem is that it wasnt erasing the attachments so we had to add that empty array on attachments.
lets add the update in another pr once i had some trouble with this remove logics and dont really want to have the same kind of problems in the update before moving the sprint card lol
CLA
Description of the changes, What, Why and How?
Changelog