Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude system message from unread count #777

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Sep 27, 2021

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why, and How?

Reference - https://stream-io.atlassian.net/browse/CRNS-406
Reference Issue - #739

Changelog

Files changed are:

  • src/channel.ts
  • test/unit/channel.js

@github-actions
Copy link
Contributor

Size Change: +64 B (0%)

Total Size: 250 kB

Filename Size Change
dist/browser.es.js 54.6 kB +11 B (0%)
dist/browser.full-bundle.min.js 30.1 kB +15 B (0%)
dist/browser.js 55.3 kB +14 B (0%)
dist/index.es.js 54.7 kB +11 B (0%)
dist/index.js 55.3 kB +13 B (0%)

compressed-size-action

@khushal87 khushal87 changed the title fix: exclude system message from unread round fix: exclude system message from unread count Sep 27, 2021
@vishalnarkhede vishalnarkhede merged commit 996bc75 into master Sep 29, 2021
@vishalnarkhede vishalnarkhede deleted the khushal87-crns-406 branch September 29, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream API excludes system messages from unread_count, client code includes them
2 participants