fixed conditions on window.removeEventLister to avoid breaking on react-native

[vishalnarkhede]

CLA

• I have signed the Stream CLA (required).
• Code changes are tested

Description of the changes, What, Why and How?

We have this function within js client's connection class:

  _removeConnectionListeners = () => {
    if (
      typeof window !== 'undefined' &&
      window != null &&
      window.addEventListener != null
    ) {
      window.removeEventListener('offline', this.onlineStatusChanged);
      window.removeEventListener('online', this.onlineStatusChanged);
    }
  };

We call this function as part of disconnect logic. Although window is not a react-native thing, it just happens that some external dependencies can introduce it within global variable in react-native, causing our if checks to fail. Also clearly we are checking window.addEventListener before executing removeEventListener, which is a false check.

E.g., following piece of code within react-native replicates the issue.

global.window = {
  addEventListener: () => null,
  removeEventListener: null,
};

Changelog

• Fixed the empty check on window.addEventListener and window.removeEventListener

[github-actions]

Size Change: +441 B (0%)

Total Size: 250 kB

Filename	Size	Change
dist/browser.es.js	54.7 kB	+111 B (0%)
dist/browser.full-bundle.min.js	30.1 kB	+13 B (0%)
dist/browser.js	55.4 kB	+103 B (0%)
dist/index.es.js	54.8 kB	+111 B (0%)
dist/index.js	55.4 kB	+103 B (0%)

_{compressed-size-action}