fixed conditions on window.removeEventLister to avoid breaking on react-native #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
We have this function within js client's connection class:
We call this function as part of disconnect logic. Although
window
is not a react-native thing, it just happens that some external dependencies can introduce it within global variable in react-native, causing ourif
checks to fail. Also clearly we are checkingwindow.addEventListener
before executingremoveEventListener
, which is a false check.E.g., following piece of code within react-native replicates the issue.
Changelog