Skip to content

Commit

Permalink
feat: add gdpr flag for campaign deletion (#132)
Browse files Browse the repository at this point in the history
  • Loading branch information
ferhatelmas committed Sep 7, 2022
1 parent 93ce539 commit 5dc0c2e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions stream_chat/async_chat/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -531,9 +531,8 @@ async def query_campaigns(self, **params: Any) -> StreamResponse:
async def update_campaign(self, campaign_id: str, data: Dict) -> StreamResponse:
return await self.put(f"campaigns/{campaign_id}", data={"campaign": data})

async def delete_campaign(self, campaign_id: str) -> StreamResponse:

return await self.delete(f"campaigns/{campaign_id}")
async def delete_campaign(self, campaign_id: str, **options: Any) -> StreamResponse:
return await self.delete(f"campaigns/{campaign_id}", params=options)

async def schedule_campaign(
self, campaign_id: str, scheduled_for: int = None
Expand Down
2 changes: 1 addition & 1 deletion stream_chat/base/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ def update_campaign(

@abc.abstractmethod
def delete_campaign(
self, campaign_id: str
self, campaign_id: str, **options: Any
) -> Union[StreamResponse, Awaitable[StreamResponse]]:
"""
Delete a campaign by id
Expand Down
4 changes: 2 additions & 2 deletions stream_chat/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ def query_campaigns(self, **params: Any) -> StreamResponse:
def update_campaign(self, campaign_id: str, data: Dict) -> StreamResponse:
return self.put(f"campaigns/{campaign_id}", data={"campaign": data})

def delete_campaign(self, campaign_id: str) -> StreamResponse:
return self.delete(f"campaigns/{campaign_id}")
def delete_campaign(self, campaign_id: str, **options: Any) -> StreamResponse:
return self.delete(f"campaigns/{campaign_id}", params=options)

def schedule_campaign(
self, campaign_id: str, scheduled_for: int = None
Expand Down

0 comments on commit 5dc0c2e

Please sign in to comment.