fix: fix reply border style #2197
Conversation
| borderRightWidth: 0, | ||
| }, | ||
| }), | ||
| borderRightWidth: 0, |
There was a problem hiding this comment.
If its 0, if there a need to have this property in the styles anymore?
| borderLeftWidth: 0, | ||
| }, | ||
| }), | ||
| borderLeftWidth: 0, |
There was a problem hiding this comment.
If its 0, if there a need to have this property in the styles anymore?
There was a problem hiding this comment.
Yes, the current structure first passes styles.messageRepliesCurve with a borderWidth: 1. Then, we remove the opposite side border within each rightMessageRepliesCurve or leftMessageRepliesCurve. I've attached an image if we just remove that line.
However, if this is not ideal, we could remove the borderWidth: 1 from the styles.messageRepliesCurve and replace it with borderWithBottom: 1 and then have a left or right borderWidth with each replies curve. This should give the same impact.
|
Hey @aharwood9, thanks for fixing this and providing your valuable contributions. 馃檶馃徎 |
|
@khushal87 - sorry one additional comment. Should there be a horizontal margin or not between the curves and the avatars? See the below images. With margin - Without margin - 
Currently this PR has margin |
|
Hey @aharwood9, good point. According to the design, there should not be a margin. Can you add the fix? Thanks 馃槃 |
Done 馃憤 if you are happy with my reply to your comment about |
|
馃帀 This PR is included in version 5.18.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
馃幆 Goal
Fix #1982 and the curve wasn't showing on Android at all (hard to tell due to
MessageRepliesAvatarssitting over it)馃洜 Implementation details
flexDirection: rowto the message-replies container馃帹 UI Changes
iOS
Before -
After -
Android
Before -
After -
馃И Testing
鈽戯笍 Checklist
developbranch