-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix reply border style #2197
Changes from 4 commits
12b0cfb
8c9ca8d
fc18426
a025150
2019065
5b03fe7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import React from 'react'; | ||
import { ColorValue, Platform, StyleSheet, Text, TouchableOpacity, View } from 'react-native'; | ||
import { ColorValue, StyleSheet, Text, TouchableOpacity, View } from 'react-native'; | ||
|
||
import { | ||
MessageContextValue, | ||
|
@@ -28,15 +28,9 @@ const styles = StyleSheet.create({ | |
}, | ||
leftMessageRepliesCurve: { | ||
borderBottomLeftRadius: 16, | ||
borderRightColor: 'transparent', | ||
...Platform.select({ | ||
android: { | ||
borderRightWidth: 0, | ||
}, | ||
}), | ||
borderRightWidth: 0, | ||
}, | ||
messageRepliesCurve: { | ||
borderTopColor: 'transparent', | ||
borderTopWidth: 0, | ||
borderWidth: 1, | ||
height: 16, | ||
|
@@ -46,16 +40,11 @@ const styles = StyleSheet.create({ | |
fontSize: 12, | ||
fontWeight: '700', | ||
paddingBottom: 5, | ||
paddingLeft: 8, | ||
paddingHorizontal: 8, | ||
}, | ||
rightMessageRepliesCurve: { | ||
borderBottomRightRadius: 16, | ||
borderLeftColor: 'transparent', | ||
...Platform.select({ | ||
android: { | ||
borderLeftWidth: 0, | ||
}, | ||
}), | ||
borderLeftWidth: 0, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If its 0, if there a need to have this property in the styles anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the current structure first passes ![]() However, if this is not ideal, we could remove the |
||
}, | ||
}); | ||
|
||
|
@@ -112,7 +101,7 @@ const MessageRepliesWithContext = < | |
return ( | ||
<View style={styles.curveContainer}> | ||
{alignment === 'left' && ( | ||
<View testID='message-replies-left'> | ||
<View style={styles.curveContainer} testID='message-replies-left'> | ||
{!noBorder && ( | ||
<View | ||
style={[ | ||
|
@@ -166,7 +155,7 @@ const MessageRepliesWithContext = < | |
</Text> | ||
</TouchableOpacity> | ||
{alignment === 'right' && ( | ||
<View testID='message-replies-right'> | ||
<View style={styles.curveContainer} testID='message-replies-right'> | ||
<MessageRepliesAvatars alignment={alignment} message={message} /> | ||
{!noBorder && ( | ||
<View | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its 0, if there a need to have this property in the styles anymore?