fix: remove return null check from OverlayProvider and Chat component

[khushal87]

🎯 Goal

Fixes #2037

🛠 Implementation details

🎨 UI Changes

iOS

Before	After

Android

Before	After

🧪 Testing

☑️ Checklist

• I have signed the Stream CLA (required)
• PR targets the develop branch
• Documentation is updated
• New code is tested in main example apps, including all possible scenarios
  • SampleApp iOS and Android
  • Expo iOS and Android

[santhoshvai]

Also, I think it is a good idea to remove some parts from useEffect so that it happens during render and not after the render maybe using usememo or bringing the translators state inside.. this whole hook seems badly done in the first place in my view 😢

I am talking about the following parts

    let streami18n: Streami18n;

    if (i18nInstance instanceof Streami18n) {
      streami18n = i18nInstance;
    } else {
      streami18n = new Streami18n({ language: 'en' });
    }

     streami18n.getTranslators().then((translator) => {
      if (translator && isMounted.current) setTranslators(translator);
    });

There is no reason to run the promise after the render actually if you think about it.. What say?

[khushal87]

I have moved the translator state inside, because it makes sense to me.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[vishalnarkhede]

Make sure to test it by adding some delays to streami18n.getTranslators() method. Just to check whats the behavior when translators is not ready

[stream-ci-bot]

🎉 This PR is included in version 5.14.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀