Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AutoCompleteInput setInputBoxRef typing #2095

Merged
merged 3 commits into from
May 11, 2023

Conversation

vanGalilea
Copy link
Contributor

🎯 Goal

Fixes #1362

🛠 Implementation details

Use correct type

🎨 UI Changes

N/A

🧪 Testing

To Reproduce
Steps to reproduce the behavior:

const messageInputRef = useRef<TextInput>(null)

return <AutoCompleteInput setInputBoxRef={messageInputRef}/>

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@vanGalilea vanGalilea requested a review from khushal87 May 10, 2023 16:22
…o fix/autocomplete-ref-typing

# Conflicts:
#	package/src/contexts/messageInputContext/MessageInputContext.tsx
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vanGalilea vanGalilea merged commit 9fd7cfc into develop May 11, 2023
8 checks passed
@vanGalilea vanGalilea deleted the fix/autocomplete-ref-typing branch May 11, 2023 14:17
@github-actions github-actions bot mentioned this pull request May 11, 2023
vanGalilea added a commit that referenced this pull request May 12, 2023
* chore: adding needed info to bug report template (#2087)

* chore: adding needed info to bug report template

* chore: adding needed info to bug report template

* adding yarn.lock

* Delete Podfile.lock

* Chore: fixing broken android ci (#2089)

* chore: adding needed info to bug report template

* chore: adding needed info to bug report template

* adding yarn.lock

* Delete Podfile.lock

* fix: android build by adding missing ReactNativeFlipper.java for release

* Update bug_report.md (#2090)

* docs: dont install a sepc. react-native-quick-sqlite version and contemp. comp. version table (#2091)

* Delete shared

* docs: adding sonar badge (#2096)

* fix: AutoCompleteInput setInputBoxRef typing (#2095)

* fix: AutoCompleteInput setInputBoxRef typing

* fix: AutoCompleteInput setInputBoxRef typing

* fix: make ws connection more robust when user is not set yet (#2098)

* fix: check whether client.userID (connecting user started at least) exists before opening a connection

* fix: check whether client.userID (connecting user started at least) exists before opening a connection

* podfile + yarn.lock
@github-actions github-actions bot mentioned this pull request May 12, 2023
vanGalilea added a commit that referenced this pull request May 12, 2023
* chore: adding needed info to bug report template (#2087)

* chore: adding needed info to bug report template

* chore: adding needed info to bug report template

* adding yarn.lock

* Delete Podfile.lock

* Chore: fixing broken android ci (#2089)

* chore: adding needed info to bug report template

* chore: adding needed info to bug report template

* adding yarn.lock

* Delete Podfile.lock

* fix: android build by adding missing ReactNativeFlipper.java for release

* Update bug_report.md (#2090)

* docs: dont install a sepc. react-native-quick-sqlite version and contemp. comp. version table (#2091)

* Delete shared

* docs: adding sonar badge (#2096)

* fix: AutoCompleteInput setInputBoxRef typing (#2095)

* fix: AutoCompleteInput setInputBoxRef typing

* fix: AutoCompleteInput setInputBoxRef typing

* fix: make ws connection more robust when user is not set yet (#2098)

* fix: check whether client.userID (connecting user started at least) exists before opening a connection

* fix: check whether client.userID (connecting user started at least) exists before opening a connection

* podfile + yarn.lock

* fix: forcing release

---------

Co-authored-by: Steve Galili <steve.galili@getstream.io>
@github-actions github-actions bot mentioned this pull request May 15, 2023
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setInputBoxRef type of AutoCompleteInput is incorrect
2 participants