fix: make ws connection more robust when user is not set yet #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists before opening a connection
…xists before opening a connection
…r-id' into hotfix/ws-connection-unknown-user-id # Conflicts: # package/src/components/Chat/hooks/useIsOnline.ts
|
Kudos, SonarCloud Quality Gate passed! |
santhoshvai
approved these changes
May 12, 2023
Merged
vanGalilea
added a commit
that referenced
this pull request
May 12, 2023
* chore: adding needed info to bug report template (#2087) * chore: adding needed info to bug report template * chore: adding needed info to bug report template * adding yarn.lock * Delete Podfile.lock * Chore: fixing broken android ci (#2089) * chore: adding needed info to bug report template * chore: adding needed info to bug report template * adding yarn.lock * Delete Podfile.lock * fix: android build by adding missing ReactNativeFlipper.java for release * Update bug_report.md (#2090) * docs: dont install a sepc. react-native-quick-sqlite version and contemp. comp. version table (#2091) * Delete shared * docs: adding sonar badge (#2096) * fix: AutoCompleteInput setInputBoxRef typing (#2095) * fix: AutoCompleteInput setInputBoxRef typing * fix: AutoCompleteInput setInputBoxRef typing * fix: make ws connection more robust when user is not set yet (#2098) * fix: check whether client.userID (connecting user started at least) exists before opening a connection * fix: check whether client.userID (connecting user started at least) exists before opening a connection * podfile + yarn.lock
Merged
vanGalilea
added a commit
that referenced
this pull request
May 12, 2023
* chore: adding needed info to bug report template (#2087) * chore: adding needed info to bug report template * chore: adding needed info to bug report template * adding yarn.lock * Delete Podfile.lock * Chore: fixing broken android ci (#2089) * chore: adding needed info to bug report template * chore: adding needed info to bug report template * adding yarn.lock * Delete Podfile.lock * fix: android build by adding missing ReactNativeFlipper.java for release * Update bug_report.md (#2090) * docs: dont install a sepc. react-native-quick-sqlite version and contemp. comp. version table (#2091) * Delete shared * docs: adding sonar badge (#2096) * fix: AutoCompleteInput setInputBoxRef typing (#2095) * fix: AutoCompleteInput setInputBoxRef typing * fix: AutoCompleteInput setInputBoxRef typing * fix: make ws connection more robust when user is not set yet (#2098) * fix: check whether client.userID (connecting user started at least) exists before opening a connection * fix: check whether client.userID (connecting user started at least) exists before opening a connection * podfile + yarn.lock * fix: forcing release --------- Co-authored-by: Steve Galili <steve.galili@getstream.io>
Merged
|
🎉 This PR is included in version 5.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
One of our customers experienced a crash on prod. due to a combination of:
🛠 Implementation details
🎨 UI Changes
N/A
🧪 Testing
client.connectUser(...withenabledOfflineSupport={true}option☑️ Checklist
developbranch