Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the image gallery header to use user id instead of user name #2165

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

Bogdastotel
Copy link
Contributor

@Bogdastotel Bogdastotel commented Jul 2, 2023

馃幆 Goal

photo.user.name is undefined (not existing in the photo response) leading to the 'Unknown user' info on the photo sender username.

馃洜 Implementation details

changed one file to user user.id or user.name if it gets fixed sometime
Bellow is the screenshot of the issue. adding photo.user.id fixes that

Simulator Screen Shot - iPhone 14 Pro - 2023-07-01 at 21 14 55

馃帹 UI Changes

iOS Was 'Unkwown user' Shows the real username of the photo sender
    </tr>
</thead>
<tbody>
    <tr>
        <td>
            <!--<img src="" /> -->
        </td>
        <td>
            <!--<img src="" /> -->
        </td>
    </tr>
</tbody>
BeforeAfter
Android
Before After

馃И Testing

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

Updated  image gallery header component username to use photo?.user?.id instead of photo?.user?.name (because "name" is currently undefined)
khushal87
khushal87 previously approved these changes Jul 6, 2023
@khushal87 khushal87 dismissed their stale review July 6, 2023 10:47

Waiting for checks to run

@khushal87
Copy link
Member

Hey @Bogdastotel, can you go through the PR checks and fix them? Thanks 馃槃

@Bogdastotel
Copy link
Contributor Author

@khushal87 sure

@Bogdastotel Bogdastotel changed the title Update image gallery header to use user.id instead of user.name (user.name is currently undefined) Update image gallery header to use user id instead of user name Jul 6, 2023
@khushal87 khushal87 changed the title Update image gallery header to use user id instead of user name fix: Update image gallery header to use user id instead of user name Jul 7, 2023
@Bogdastotel Bogdastotel changed the title fix: Update image gallery header to use user id instead of user name fix: Update the image gallery header to use user id instead of user name Jul 8, 2023
@Bogdastotel
Copy link
Contributor Author

@khushal87 i've added the secret sonar token, you can approve the checks to see if it will pass

@khushal87
Copy link
Member

Thanks @Bogdastotel

@khushal87 khushal87 merged commit 032b308 into GetStream:develop Jul 13, 2023
2 of 3 checks passed
@stream-ci-bot
Copy link
Contributor

馃帀 This PR is included in version 5.15.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants