Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
During hot module reload, the app may throw the following error
the HMR error was because the channel preview component rerendered during HMR of a global variable. This doesn't happen in our sample apps, but our awesome customer had made a repro at https://github.com/farmstrong8/stream-chat-rn-render
My theory is that due to some specific usage of react navigation the component rerenders.
But anyway we should not break HMRs.
After this fix, if the customer doesn't rerender the channel list after disconnect this error shouldn't happen. If customers render this error makes sense anyway.
馃洜 Implementation details
NA
馃帹 UI Changes
NA
鈽戯笍 Checklist
develop
branch