Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not render message list items when channel is disconnected #2179

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

santhoshvai
Copy link
Member

馃幆 Goal

A quick dirty fix for HMR issue with react navigation on cleanup as described in #2169. This should be looked at later to turn the last read state to be more reactive

馃洜 Implementation details

NA

馃帹 UI Changes

NA

馃И Testing

NA

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai merged commit 53d29c2 into develop Jul 11, 2023
5 of 6 checks passed
@santhoshvai santhoshvai deleted the fix/hmr-issue-messagelist branch July 11, 2023 15:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions github-actions bot mentioned this pull request Jul 11, 2023
@stream-ci-bot
Copy link
Contributor

馃帀 This PR is included in version 5.15.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants