Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request MessageActions to allow MessageActionProps to accept custom aria label for button #1931

Closed
tedderple opened this issue Feb 9, 2023 · 4 comments · Fixed by #2282
Closed

Request MessageActions to allow MessageActionProps to accept custom aria label for button #1931

tedderple opened this issue Feb 9, 2023 · 4 comments · Fixed by #2282
Labels
cluster:a11y Issues related to improvement of a11y customization and coverage feature New capability released

Comments

@tedderple
Copy link

Motivation
I'd like to request the ability to pass in a custom aria-label for the button found in

stream-chat-react/src/components/MessageActions/MessageActions.tsx

Line 134 in 03fbe2b

aria-label='Open Message Actions Menu'

Proposed solution
Optional MessageActionProp that accepts a string that can be passed to alter button aria-label

Acceptance Criteria

  • If prop is not passed in, then it defaults to "Open Message Actions Menu"
  • If a custom aria-label prop string is passed in, the button takes that custom string
@tedderple tedderple added the feature New capability label Feb 9, 2023
@MartinCupela
Copy link
Contributor

@tedderple there will be probably more places, where you may want us to provide you with customization of accessibility labels. We will not prioritize this task at the moment.

@MartinCupela
Copy link
Contributor

We still need to take a look, when this could be done.

@MartinCupela MartinCupela added the cluster:a11y Issues related to improvement of a11y customization and coverage label Feb 10, 2023
@tedderple
Copy link
Author

Thank you

@tedderple tedderple reopened this Feb 17, 2023
@MartinCupela MartinCupela mentioned this issue Apr 18, 2023
Closed
@myandrienko myandrienko mentioned this issue Feb 15, 2024
Merged
1 task
myandrienko added a commit that referenced this issue Feb 21, 2024
@myandrienko
feat: make aria-labels localizable (#2282)
7867677 
### 🎯 Goal

We had several requests related to customization of `aria-label`
attributes. The best approach is to rely on existing
internationalization support for customization and overrides.

Fixes #1931, fixes #1994.

### 🛠 Implementation details

1. Wrapped all ARIA labels in `t(...)` translation function. The keys
used for ARIA labels are prefixed with `aria/...` to distinguish them
from other texts.
2. Added default translations for supported languages.

### 🎨 UI Changes

No visible changes.

### To-Do

- [x] Update docs
github-actions bot pushed a commit that referenced this issue Feb 21, 2024
@semantic-release-bot
chore(release): 11.9.0 [skip ci]
0ef1ba5 
## [11.9.0](v11.8.0...v11.9.0) (2024-02-21)

### Bug Fixes

* add aria-expanded attribute to emoji picker and reactions selector ([#2274](#2274)) ([b15cdd5](b15cdd5))
* mark channel read on scroll to bottom of the main message list ([#2283](#2283)) ([d04d0ab](d04d0ab))
* prevent layout shifts in reactions modal ([#2272](#2272)) ([706cf3d](706cf3d))
* trap focus in opened modal ([#2278](#2278)) ([8f48b52](8f48b52))

### Features

* make aria-labels localizable ([#2282](#2282)) ([7867677](7867677)), closes [#1931](#1931) [#1994](#1994)
@stream-ci-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster:a11y Issues related to improvement of a11y customization and coverage feature New capability released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make aria-labels localizable GetStream/stream-chat-react
3 participants
@tedderple @stream-ci-bot @MartinCupela