feat: make aria-labels localizable #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Feb 15, 2024
|
Size Change: +37.1 kB (+2%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
myandrienko
commented
Feb 15, 2024
| export const mockTranslationContext = { | ||
| // Mock translation function that always falls back to the key. | ||
| // It also handles nested keys, e.g. 'aria/Send' will fall back to 'Send'. | ||
| t: (key) => key.split('/').pop(), |
There was a problem hiding this comment.
We don't load translations in tests, so all translations fall back to their keys. However, we want translations like t('aria/Send') to fall back to 'Send' and not 'aria/Send'
For test cases where that's an issue, mockTranslationContext can be provided.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
+ Coverage 84.82% 84.86% +0.03%
==========================================
Files 344 344
Lines 7573 7596 +23
Branches 2106 2106
==========================================
+ Hits 6424 6446 +22
- Misses 806 807 +1
Partials 343 343 ☔ View full report in Codecov by Sentry. |
myandrienko
commented
Feb 15, 2024
myandrienko
requested review from
arnautov-anton,
MartinCupela and
oliverlaz
MartinCupela
approved these changes
Feb 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
## [11.9.0](v11.8.0...v11.9.0) (2024-02-21) ### Bug Fixes * add aria-expanded attribute to emoji picker and reactions selector ([#2274](#2274)) ([b15cdd5](b15cdd5)) * mark channel read on scroll to bottom of the main message list ([#2283](#2283)) ([d04d0ab](d04d0ab)) * prevent layout shifts in reactions modal ([#2272](#2272)) ([706cf3d](706cf3d)) * trap focus in opened modal ([#2278](#2278)) ([8f48b52](8f48b52)) ### Features * make aria-labels localizable ([#2282](#2282)) ([7867677](7867677)), closes [#1931](#1931) [#1994](#1994)
|
🎉 This PR is included in version 11.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We had several requests related to customization of
aria-labelattributes. The best approach is to rely on existing internationalization support for customization and overrides.Fixes #1931, fixes #1994.
🛠 Implementation details
t(...)translation function. The keys used for ARIA labels are prefixed witharia/...to distinguish them from other texts.🎨 UI Changes
No visible changes.
To-Do