fix: add aria-expanded attribute to emoji picker and reactions selector #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
changed the title
myandrienko
force-pushed
the
fix/aria-expanded
branch
from
9d7192f
to
8bd3295
Compare
myandrienko
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2274 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 344 344
Lines 7572 7573 +1
Branches 2106 2106
=======================================
+ Hits 6423 6424 +1
Misses 806 806
Partials 343 343 ☔ View full report in Codecov by Sentry. |
|
Size Change: +124 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
myandrienko
requested review from
arnautov-anton and
MartinCupela
and removed request for
arnautov-anton
arnautov-anton
approved these changes
Feb 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
## [11.9.0](v11.8.0...v11.9.0) (2024-02-21) ### Bug Fixes * add aria-expanded attribute to emoji picker and reactions selector ([#2274](#2274)) ([b15cdd5](b15cdd5)) * mark channel read on scroll to bottom of the main message list ([#2283](#2283)) ([d04d0ab](d04d0ab)) * prevent layout shifts in reactions modal ([#2272](#2272)) ([706cf3d](706cf3d)) * trap focus in opened modal ([#2278](#2278)) ([8f48b52](8f48b52)) ### Features * make aria-labels localizable ([#2282](#2282)) ([7867677](7867677)), closes [#1931](#1931) [#1994](#1994)
|
🎉 This PR is included in version 11.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This fixes an accessibility issue with the
EmojiPickerand reactions selector: their respective tigger buttons should havearia-expandedattribute, as per the Menu Button ARIA pattern.🎨 UI Changes
No visible changes.