feat: allow to configure channel query options #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +167 B (0%) Total Size: 1.91 MB
鈩癸笍 View Unchanged
|
oliverlaz
reviewed
Nov 16, 2023
oliverlaz
approved these changes
Nov 16, 2023
|
馃帀 This PR is included in version 10.20.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [11.0.0-rc.8](v11.0.0-rc.7...v11.0.0-rc.8) (2023-11-22) ### Bug Fixes * calculate pagination stop from custom channel query message limit ([#2180](#2180)) ([8374af1](8374af1)) * lift notifications above modal overlay ([#2175](#2175)) ([17d98f4](17d98f4)) ### Features * allow to configure channel query options ([#2177](#2177)) ([4f91d9a](4f91d9a))
|
馃帀 This PR is included in version 11.0.0-rc.8 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
At the moment, user cannot specify, how the first channel page will look like, when they pass uninitialized
Channelinstance intoChannelcomponent props. With this feature, theChannelQueryOptionsobject will be propagated to all thechannel.watch()calls inside theChannelcomponent context.Note
This PR does not tackle providing channel query options inside
ChannelListcontext. There thechannel.watch()call is performed on the following events:notification.added_to_channelchannel.visiblenotification.message_newIn these cases, the users can pass custom handler functions, that can perform watch queries with custom query options.