fix: calculate pagination stop from custom channel query message limit #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +699 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Nov 20, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
## [10.20.1](v10.20.0...v10.20.1) (2023-11-20) ### Bug Fixes * calculate pagination stop from custom channel query message limit ([#2180](#2180)) ([8374af1](8374af1))
|
🎉 This PR is included in version 10.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [11.0.0-rc.8](v11.0.0-rc.7...v11.0.0-rc.8) (2023-11-22) ### Bug Fixes * calculate pagination stop from custom channel query message limit ([#2180](#2180)) ([8374af1](8374af1)) * lift notifications above modal overlay ([#2175](#2175)) ([17d98f4](17d98f4)) ### Features * allow to configure channel query options ([#2177](#2177)) ([4f91d9a](4f91d9a))
|
🎉 This PR is included in version 11.0.0-rc.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 10.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The logic to determine whether there are more messages to be loaded from the API was flawed because it relied on the expectation that the first page size will be always constant determined by the SDK. But once the integrators perform the initial channel query outside the
Channelcomponent with custom query options different from the SDK constant defaultor they specify this through
ChannelpropchannelQueryOptions, then the custom value has to be taken into the consideration. Otherwise if the custom first page size was smaller then the default, the next page would not be loaded.This PR brings a small optimization when the
hasMoreflag is set on theChannelcomponent state immediately after the first query resp. also for already initialized channel in the layout effect.