feat: add BaseImage component with image fallback display #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2183 +/- ##
==========================================
+ Coverage 83.64% 83.76% +0.12%
==========================================
Files 308 314 +6
Lines 7129 7196 +67
Branches 2018 2034 +16
==========================================
+ Hits 5963 6028 +65
+ Misses 832 831 -1
- Partials 334 337 +3 ☔ View full report in Codecov by Sentry. |
|
Size Change: -45.5 kB (-3%) Total Size: 1.67 MB
ℹ️ View Unchanged
|
szuperaz
reviewed
Nov 24, 2023
szuperaz
approved these changes
Nov 27, 2023
arnautov-anton
force-pushed
the
master
branch
from
2cc3b70
to
a510e8f
Compare
docusaurus/docs/React/components/utility-components/base-image.mdx
Outdated
Show resolved
Hide resolved
docusaurus/docs/React/components/utility-components/base-image.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
| ...generateChannelOptions, | ||
| }); | ||
| const client = await getTestClientWithUser(user); | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks |
There was a problem hiding this comment.
I see linter got confused a little. 😄
arnautov-anton
approved these changes
Nov 28, 2023
oliverlaz
approved these changes
Nov 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
## [11.1.0](v11.0.0...v11.1.0) (2023-12-01) ### Bug Fixes * revert "feat: expose channels state on chat level ([#2161](#2161))" ([#2184](#2184)) ([32e4867](32e4867)) ### Features * add BaseImage component with image fallback display ([#2183](#2183)) ([ec1d79b](ec1d79b)) * add channel list context ([#2187](#2187)) ([fd5ea67](fd5ea67)) * render BaseImage image fallback within the same img element ([#2200](#2200)) ([2fcd564](2fcd564)) ### Chores * **deps:** bump @stream-io/stream-chat-css from 4.0.0 to 4.1.0 ([e600e3c](e600e3c)) * **deps:** bump stream-chat from 8.14.3 to 8.14.4 ([#2199](#2199)) ([a4dd57f](a4dd57f)) * **deps:** move `@stream-io/stream-chat-css` to `devDeps` ([#2191](#2191)) ([61af19c](61af19c))
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide a base image component that renders an image or its fallback in case the image could not be loaded.
depends on GetStream/stream-chat-css#251
fixes #2182
🎨 UI Changes
See file changes.
Todo