feat: remove legacy style components #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
reviewed
May 21, 2024
# Conflicts: # docusaurus/docs/React/components/message-input-components/ui-components.mdx # src/components/Attachment/AttachmentContainer.tsx # src/components/Attachment/UnsupportedAttachment.tsx # src/components/MessageInput/AttachmentPreviewList.tsx # src/components/MessageInput/hooks/useMessageInputState.ts
…ar--one-letter to Avatar
|
Size Change: -94.2 kB (-4.39%) Total Size: 2.05 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
+ Coverage 85.28% 85.35% +0.06%
==========================================
Files 392 372 -20
Lines 9027 8487 -540
Branches 2322 2132 -190
==========================================
- Hits 7699 7244 -455
+ Misses 1120 1065 -55
+ Partials 208 178 -30 ☔ View full report in Codecov by Sentry. |
…to feat/remove-legacy-style-components # Conflicts: # src/components/MessageInput/MessageInputFlat.tsx # src/i18n/pt.json
…nts' into feat/remove-legacy-style-components
# Conflicts: # src/components/MessageInput/MessageInputFlat.tsx # src/components/MessageInput/__tests__/MessageInput.test.js
oliverlaz
approved these changes
May 27, 2024
arnautov-anton
pushed a commit
that referenced
this pull request
May 29, 2024
BREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information BREAKING CHANGE: theme v1 related markup and classNames have been removed BREAKING CHANGE: `themeVersion` property has been removed from `ChatContext`
MartinCupela
added a commit
that referenced
this pull request
Jun 12, 2024
BREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information BREAKING CHANGE: theme v1 related markup and classNames have been removed BREAKING CHANGE: `themeVersion` property has been removed from `ChatContext`
MartinCupela
added a commit
that referenced
this pull request
Jun 17, 2024
BREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information BREAKING CHANGE: theme v1 related markup and classNames have been removed BREAKING CHANGE: `themeVersion` property has been removed from `ChatContext`
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
## [12.0.0-rc.1](v11.21.0...v12.0.0-rc.1) (2024-06-17) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([fcaafb6](fcaafb6)) ### Features * remove legacy style components ([#2394](#2394)) ([9410153](9410153))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Remove all the code related to deprecated stylesheet in @stream-io/stream-chat-css.
Depends on GetStream/stream-chat-css#296
🛠 Implementation details
Drop
themeVersionproperty from ChatContext/ChatProvider ✅Drop all of the markup which relies on
themeVersiondetailedViewprop if markup displayed with it is not styled in v2?remove V1-related
classNamesfrom components which work with both versions ✅drop theme-V1-related deprecated components
dist/css/v2folder todist/css, drop v2 folder ✅Chatcomponent propcustomStylesand associated code ✅$stream-chat-theme-version: '2';from example apps’ CSS ✅Out of scope
--str-chat__theme-versionfrom CSS docs - global-variables.mdx - needs change in generation scriptsBREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information
BREAKING CHANGE: theme v1 related markup and classNames have been removed
BREAKING CHANGE:
themeVersionproperty has been removed fromChatContext