fix: render typing indicator outside the VirtualizedMessageList scroll container #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information BREAKING CHANGE: theme v1 related markup and classNames have been removed BREAKING CHANGE: `themeVersion` property has been removed from `ChatContext`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2406 +/- ##
==========================================
- Coverage 85.42% 85.38% -0.04%
==========================================
Files 372 372
Lines 8488 8487 -1
Branches 2133 2133
==========================================
- Hits 7251 7247 -4
- Misses 1059 1061 +2
- Partials 178 179 +1 ☔ View full report in Codecov by Sentry. |
|
Size Change: -72 B (0%) Total Size: 2.05 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
May 31, 2024
MartinCupela
added a commit
that referenced
this pull request
Jun 12, 2024
…l container (#2406) BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel
MartinCupela
added a commit
that referenced
this pull request
Jun 17, 2024
…l container (#2406) BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
## [12.0.0-rc.1](v11.21.0...v12.0.0-rc.1) (2024-06-17) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([fcaafb6](fcaafb6)) ### Features * remove legacy style components ([#2394](#2394)) ([9410153](9410153))
arnautov-anton
pushed a commit
that referenced
this pull request
Jun 28, 2024
…l container (#2406) BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel
arnautov-anton
pushed a commit
that referenced
this pull request
Jun 28, 2024
* The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([fcaafb6](fcaafb6)) * remove legacy style components ([#2394](#2394)) ([9410153](9410153))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
## [12.0.0-rc.1](v11.23.0...v12.0.0-rc.1) (2024-07-01) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([9f5485d](9f5485d)) ### Features * remove legacy style components ([#2394](#2394)) ([cf40d56](cf40d56)) ### Chores * **deps:** bump @stream-io/stream-chat-css to version 5.0.0-rc.1nvm ([be132cb](be132cb))
MartinCupela
added a commit
that referenced
this pull request
Jul 1, 2024
…l container (#2406) BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel
MartinCupela
pushed a commit
that referenced
this pull request
Jul 1, 2024
## [12.0.0-rc.1](v11.21.0...v12.0.0-rc.1) (2024-06-17) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([fcaafb6](fcaafb6)) ### Features * remove legacy style components ([#2394](#2394)) ([9410153](9410153))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
## [12.0.0-rc.1](v11.23.0...v12.0.0-rc.1) (2024-07-01) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([d9442d2](d9442d2)) ### Features * remove legacy style components ([#2394](#2394)) ([7bf63ae](7bf63ae)) ### Chores * **deps:** bump @stream-io/stream-chat-css to version 5.0.0-rc.1nvm ([e9cf42f](e9cf42f))
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
## [12.0.0-rc.1](v11.23.0...v12.0.0-rc.1) (2024-07-01) ### ⚠ BREAKING CHANGES * The VirtualizedMessageList does not provide default Footer component * The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel * stylesheet import path changed & v1 stylesheet has been dropped, see release guide for more information * theme v1 related markup and classNames have been removed * `themeVersion` property has been removed from `ChatContext` ### Bug Fixes * render typing indicator outside the VirtualizedMessageList scroll container ([#2406](#2406)) ([d9442d2](d9442d2)) ### Features * remove legacy style components ([#2394](#2394)) ([7bf63ae](7bf63ae)) ### Chores * **deps:** bump @stream-io/stream-chat-css to version 5.0.0-rc.1nvm ([e9cf42f](e9cf42f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Prevent rendering the TypingIndicator at the bottom of the VML scroll container. This lead to the indicator component not to be visible because the container is not scrolled to the bottom when the indicator is rendered.
fix #1941
BREAKING CHANGE: The VirtualizedMessageList does not provide default Footer component
BREAKING CHANGE: The VirtualizedMessageList markup has changed as TypingIndicator is rendered as a child of MessageListMainPanel