Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to customize MessageStatus UI by message delivery status #2405

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

MartinCupela
Copy link
Contributor

@MartinCupela MartinCupela commented May 28, 2024

🎯 Goal

fix #1633

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (5d00b56) to head (37ed396).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-v11    #2405      +/-   ##
===============================================
+ Coverage        85.33%   85.39%   +0.05%     
===============================================
  Files              392      392              
  Lines             9028     9030       +2     
  Branches          2323     2326       +3     
===============================================
+ Hits              7704     7711       +7     
  Misses            1116     1116              
+ Partials           208      203       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +94 to +95
{themeVersion === '1' && <Tooltip>{t<string>('Sending...')}</Tooltip>}
{themeVersion === '2' && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this collide with your v12 PR? I think we shouldn't be adding features to v11 anymore - let's scrap the theme stuff and make this a part of v12 release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, but that can happen with many fixes that will be done in future days. This one is a small one, so should not be problem to port it to v12.

@MartinCupela MartinCupela merged commit 7929bc2 into release-v11 Jun 3, 2024
9 of 10 checks passed
@MartinCupela MartinCupela deleted the feat/customize-message-status-ui branch June 3, 2024 10:12
MartinCupela added a commit that referenced this pull request Jun 3, 2024
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
## [11.20.0](v11.19.0...v11.20.0) (2024-06-07)

### Bug Fixes

* make it possible to jump to system messages in MessageList ([#2404](#2404)) ([6cb81c5](6cb81c5))
* reflect separateGiphyPreview prop value in VirtualizedMessageList ([#2402](#2402)) ([5d00b56](5d00b56))
* update quoting message on update of quoted message ([#2408](#2408)) ([4ec3518](4ec3518))

### Features

* allow custom class on Modal root div ([#2410](#2410)) ([b614eff](b614eff))
* allow to customize MessageStatus UI by message delivery status ([#2405](#2405)) ([7929bc2](7929bc2))
* memoize & add highlightDuration parameter to jumpTo[FirstUnread]Message ([#2414](#2414)) ([305d4f3](305d4f3))

### Chores

* **deps:** bump stream-chat to v8.33.1 ([ded8f05](ded8f05))
@stream-ci-bot
Copy link
Collaborator

🎉 This PR is included in version 11.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants