feat: allow custom class on Modal root div #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2410 +/- ##
============================================
Coverage 85.33% 85.33%
============================================
Files 392 392
Lines 9028 9029 +1
Branches 2323 2323
============================================
+ Hits 7704 7705 +1
Misses 1116 1116
Partials 208 208 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
May 31, 2024
| @@ -42,7 +45,7 @@ export const Modal = ({ children, onClose, open }: PropsWithChildren<ModalProps> | |||
| if (!open) return null; | |||
|
|
|||
| return ( | |||
| <div className='str-chat__modal str-chat__modal--open' onClick={handleClick}> | |||
| <div className={clsx('str-chat__modal str-chat__modal--open', className)} onClick={handleClick}> | |||
There was a problem hiding this comment.
str-chat__modal--open - that's funny
There was a problem hiding this comment.
I would not remove it as it would be a breaking change
There was a problem hiding this comment.
I know, I'm not suggesting - treat this as "completely useless comment". :)
arnautov-anton
approved these changes
May 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## [11.20.0](v11.19.0...v11.20.0) (2024-06-07) ### Bug Fixes * make it possible to jump to system messages in MessageList ([#2404](#2404)) ([6cb81c5](6cb81c5)) * reflect separateGiphyPreview prop value in VirtualizedMessageList ([#2402](#2402)) ([5d00b56](5d00b56)) * update quoting message on update of quoted message ([#2408](#2408)) ([4ec3518](4ec3518)) ### Features * allow custom class on Modal root div ([#2410](#2410)) ([b614eff](b614eff)) * allow to customize MessageStatus UI by message delivery status ([#2405](#2405)) ([7929bc2](7929bc2)) * memoize & add highlightDuration parameter to jumpTo[FirstUnread]Message ([#2414](#2414)) ([305d4f3](305d4f3)) ### Chores * **deps:** bump stream-chat to v8.33.1 ([ded8f05](ded8f05))
|
🎉 This PR is included in version 11.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to apply specific styles to different modal scenarios.