Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1009] Fix the appearance of system messages #1281

Merged
merged 2 commits into from Jul 16, 2021

Conversation

SagarSDagdu
Copy link
Contributor

What does this PR do

  • This PR fixes the appearance of the system messages in the channel
Before After
before.png after.png

@Stream-iOS-Bot
Copy link
Collaborator

1 Message
📖 Skipping Danger since PR is classed as Draft

Generated by 🚫 Danger

Copy link
Contributor

@evsaev evsaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarSDagdu SagarSDagdu force-pushed the CIS-1009-system-messages-appearance branch from 7b292cd to d2504d7 Compare July 16, 2021 04:13
@SagarSDagdu SagarSDagdu force-pushed the CIS-1009-system-messages-appearance branch from 4aea8a3 to 5d75f77 Compare July 16, 2021 04:17
@codecov-commenter
Copy link

Codecov Report

Merging #1281 (4aea8a3) into main (c3db2e0) will decrease coverage by 0.38%.
The diff coverage is n/a.

❗ Current head 4aea8a3 differs from pull request most recent head 5d75f77. Consider uploading reports for the commit 5d75f77 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   91.65%   91.26%   -0.39%     
==========================================
  Files         219      219              
  Lines        9488     9488              
==========================================
- Hits         8696     8659      -37     
- Misses        792      829      +37     
Flag Coverage Δ
llc-tests 91.26% <ø> (ø)
llc-tests-ios12 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ocketClient/Engine/StarscreamWebSocketEngine.swift 0.00% <0.00%> (-76.20%) ⬇️
...s/StreamChat/WebSocketClient/WebSocketClient.swift 89.60% <0.00%> (-2.41%) ⬇️
.../Utils/InternetConnection/InternetConnection.swift 54.05% <0.00%> (-0.91%) ⬇️
...ources/StreamChat/Database/DatabaseContainer.swift 96.42% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3db2e0...5d75f77. Read the comment docs.

@SagarSDagdu SagarSDagdu marked this pull request as ready for review July 16, 2021 10:30
Copy link
Contributor

@DominikBucher12 DominikBucher12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@SagarSDagdu SagarSDagdu merged commit 07cfdd7 into main Jul 16, 2021
@SagarSDagdu SagarSDagdu deleted the CIS-1009-system-messages-appearance branch July 16, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants