Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imageURL encoding during connectUser #1523

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Fix imageURL encoding during connectUser #1523

merged 1 commit into from
Oct 7, 2021

Conversation

b-onc
Copy link
Contributor

@b-onc b-onc commented Oct 6, 2021

In turn, user images were not correctly displayed

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a video that shows this working properly, since it doesn't seem it fixed.

@b-onc
Copy link
Contributor Author

b-onc commented Oct 7, 2021

Simulator.Screen.Recording.-.iPhone.13.-.2021-10-07.at.13.08.34.mp4

@nuno-vieira I created a new user, which has the same JWT token as Luke Skywalker, but has a different name (Young Luke Skywalker) and a different image. When I connect with that user, Luke Skywalker becomes Young Luke Skywalker and image is correctly updated. When I login with Luke Skywalker, the image and name changes as expected. So the PR is working as expected.

If you want to test yourself, please add this to DemoUsers in DemoApp:

        (
            "luke_skywalker",
            "Young Luke Skywalker",
            "https://static.wikia.nocookie.net/starwars/images/b/b4/LukeLeiaDS1.jpg",
            "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibHVrZV9za3l3YWxrZXIifQ.kFSLHRB5X62t0Zlc7nwczWUfsQMwfkpylC6jCUZ6Mc0",
            "Tatooine"
        ),

@nuno-vieira
Copy link
Member

nuno-vieira commented Oct 7, 2021

Simulator.Screen.Recording.-.iPhone.13.-.2021-10-07.at.13.08.34.mp4
@nuno-vieira I created a new user, which has the same JWT token as Luke Skywalker, but has a different name (Young Luke Skywalker) and a different image. When I connect with that user, Luke Skywalker becomes Young Luke Skywalker and image is correctly updated. When I login with Luke Skywalker, the image and name changes as expected. So the PR is working as expected.

If you want to test yourself, please add this to DemoUsers in DemoApp:

        (
            "luke_skywalker",
            "Young Luke Skywalker",
            "https://static.wikia.nocookie.net/starwars/images/b/b4/LukeLeiaDS1.jpg",
            "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibHVrZV9za3l3YWxrZXIifQ.kFSLHRB5X62t0Zlc7nwczWUfsQMwfkpylC6jCUZ6Mc0",
            "Tatooine"
        ),

@b-onc What about changing the image of Luke skywalker ? And not a new user? The issue seems to happen when a user already exists.

@b-onc
Copy link
Contributor Author

b-onc commented Oct 7, 2021

@nuno-vieira The user id and the JWT token is the same, this is not creating a new user, this is changing an existing user's name and image. I used "creating a new user" term somewhat incorrectly, I just added an entry to our Demo Users section, it's not a new user.

@nuno-vieira
Copy link
Member

@nuno-vieira The user id and the JWT token is the same, this is not creating a new user, this is changing an existing user's name and image. I used "creating a new user" term somewhat incorrectly, I just added an entry to our Demo Users section, it's not a new user.

Nice, I see that it now works on the playground as well. Not sure why it wasn't working before, maybe the stream binary was cached.

image

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@b-onc b-onc merged commit 064e3b8 into main Oct 7, 2021
@b-onc b-onc deleted the fix-image-encoding branch October 7, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants