Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.6.0 #1715

Merged
merged 28 commits into from Dec 20, 2021
Merged

Release/4.6.0 #1715

merged 28 commits into from Dec 20, 2021

Conversation

polqf
Copy link
Contributor

@polqf polqf commented Dec 20, 2021

🔄 Changed

4.6.0

December 20, 2021

⚠️ Important

  • Dependencies are no longer exposed (this includes Nuke, SwiftyGif and Starscream). If you were using those dependencies we were exposing, you would need to import them manually. This is due to our newest addition supporting Module Stable XCFrameworks, see more below in the "Added" section.

🔄 Changed

  • Change ChatMessageLayoutOptions to a Set instead of an OptionSet for a more flexible and safer customization #1651
  • There is a new ChatMessageListDateSeparatorView component that should be used instead of the ChatMessageListScrollOverlayView if the goal is customize the styling of the date separator. Read here for more details.
  • UnknownEvent is now deprecated, use UnknownChannelEvent or UnknownUserEvent instead. #1695.
  • SwiftyGif now points to v5.4.2 that resolves crash related to leaked delegate reference.

🐞 Fixed

  • Fix stopTyping can be called on TypingEventSender after calling startTyping #1649.
  • Reactions no longer cover the text in message bubble #1666.
  • Fix error type messages rendered as user's messages and interactive #1672.
  • Fix ChannelListController makes one redundant API call #1687.
  • Safely access indexes of collections #1692.

✅ Added

  • Add support for pre-built XCFrameworks #1665.
  • Added LogConfig.destinationTypes for ease of adding new destinations to logger #1681.
  • Expose container embedding top & bottom containers by ChatChannelListItemView #1670.
  • Add Static Message List Date Separators #1686 (You can read this doc to understand how to configure this feature).
  • Adds UnknownUserEvent that models custom user event #1695.
  • ChannelQuery.options and ChannelListQuery.options are now public and mutable #1696
  • ChannelController.startWatching and stopWatching are now public. You can explicitly stop watching a channel #1696.

polqf and others added 27 commits December 15, 2021 19:38
* Add safe subscript to avoid crashing on accessing an array element

* Centralize logging + assertions in Collections extension

* Add tests for SafeSubscript

* Update Sources/StreamChatUI/Utils/Array+SafeSubscript.swift

Co-authored-by: Boris Bielik <h3sperian@gmail.com>

* Remove unneeded guard

* Apply SwiftFormat

* Update Changelog

Co-authored-by: Boris Bielik <h3sperian@gmail.com>
…#1695)

Provides new UnknownUserEvent model for custom user events
Co-authored-by: Boris Bielik <h3sperian@gmail.com>
Release 4.6.0.
* Move away from submodules

* Remove cloned repos after dependencies updates
* Pod trunk push all specs
* Updating workflow scripts along with fastfile

* Pulling in changes for updating podspecs across all Pods

Co-authored-by: Adam Rush <adam.rush@getstream.io>
@polqf polqf requested a review from a team December 20, 2021 16:23
CHANGELOG.md Outdated Show resolved Hide resolved
@nuno-vieira
Copy link
Member

@polqf Base should be main?

@polqf polqf changed the base branch from develop to main December 20, 2021 16:25
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Co-authored-by: Boris Bielik <h3sperian@gmail.com>
@adamrushy adamrushy self-requested a review December 20, 2021 16:29
@Stream-iOS-Bot
Copy link
Collaborator

1 Error
🚫 Please use more than one word.
8d07d42
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #1715 (b38e65c) into main (48f13c1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
+ Coverage   85.20%   85.24%   +0.03%     
==========================================
  Files         230      231       +1     
  Lines       11048    11071      +23     
==========================================
+ Hits         9414     9437      +23     
  Misses       1634     1634              
Flag Coverage Δ
llc-tests 85.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lient/Endpoints/Payloads/UnknownChannelEvent.swift 100.00% <ø> (ø)
Sources/StreamChat/Deprecations.swift 0.00% <ø> (ø)
...PIClient/Endpoints/Payloads/UnknownUserEvent.swift 100.00% <100.00%> (ø)
...trollers/ChannelController/ChannelController.swift 87.21% <100.00%> (ø)
...ers/EventsController/ChannelEventsController.swift 100.00% <100.00%> (ø)
Sources/StreamChat/Query/ChannelListQuery.swift 94.73% <100.00%> (ø)
Sources/StreamChat/Query/ChannelQuery.swift 100.00% <100.00%> (ø)
Sources/StreamChat/Query/QueryOptions.swift 100.00% <100.00%> (ø)
...reamChat/WebSocketClient/Events/EventDecoder.swift 78.57% <100.00%> (+3.57%) ⬆️
.../StreamChat/WebSocketClient/Events/EventType.swift 88.46% <100.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f13c1...b38e65c. Read the comment docs.

@polqf polqf merged commit 2b868ca into main Dec 20, 2021
polqf added a commit that referenced this pull request Dec 21, 2021
* Bump 4.6.0

* Adding bootstrap script to the Github action

* [CIS-1378] Safely access indexes of collections (#1692)

* Add safe subscript to avoid crashing on accessing an array element

* Centralize logging + assertions in Collections extension

* Add tests for SafeSubscript

* Update Sources/StreamChatUI/Utils/Array+SafeSubscript.swift

Co-authored-by: Boris Bielik <h3sperian@gmail.com>

* Remove unneeded guard

* Apply SwiftFormat

* Update Changelog

Co-authored-by: Boris Bielik <h3sperian@gmail.com>

* Execute generateSPMFileLists

* Add smoke checks for PRs pointing to a release branch

* Add more safety when data source index is not present by returning a valid cell

* Added docs for inline replies in the SwiftUI SDK (#1694)

* Fix reload rows out of bounds (#1697)

* Remove layout options from chat message layout options (#1698)

* Expose `QueryOptions` and `start/stopWatching` (#1696)

* UnknownEvent is now deprecated and was renamed to UnknownChannelEvent (#1695)

Provides new UnknownUserEvent model for custom user events

* Linting

* SwiftyGif 5.4.2

* Adds missing reference for source file - SwiftyGif

* Remove smoke checks

* Update CHANGELOG.md

Co-authored-by: Boris Bielik <h3sperian@gmail.com>

* Update CHANGELOG.md

* 4.6.0 Release (#1690)

Release 4.6.0.

* We need to setup the ENV for bootstrap to run correctly (including SSH Bot)

* Fixing the YML validation and fixing the CHANGELOG date entry

* Removing duplicate inside the full checks yml file

* Release 4.6.0 (#1700)

* Disabling automatic signing for both StreamChat and StreamChatUI framework

* Move away from submodules (#1709)

* Move away from submodules

* Remove cloned repos after dependencies updates

* Pod trunk push all specs (#1711)

* Pod trunk push all specs

* Updating workflow scripts along with fastfile (#1714)

* Updating workflow scripts along with fastfile

* Pulling in changes for updating podspecs across all Pods

Co-authored-by: Adam Rush <adam.rush@getstream.io>

* Update CHANGELOG.md

Co-authored-by: Boris Bielik <h3sperian@gmail.com>

Co-authored-by: Adam Rush <adam.rush@getstream.io>
Co-authored-by: Boris Bielik <h3sperian@gmail.com>
Co-authored-by: Martin Mitrevski <martinmitrevski.oh@gmail.com>
Co-authored-by: Tommaso Barbugli <tbarbugli@gmail.com>
Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
Co-authored-by: Bahadır Öncel <bahadir@getstream.io>
Co-authored-by: Boris Bielik <boris.bielik@getstream.io>
Co-authored-by: Adam Rush <adam@adr-studio.co.uk>

Co-authored-by: Adam Rush <adam.rush@getstream.io>
Co-authored-by: Boris Bielik <h3sperian@gmail.com>
Co-authored-by: Martin Mitrevski <martinmitrevski.oh@gmail.com>
Co-authored-by: Tommaso Barbugli <tbarbugli@gmail.com>
Co-authored-by: Nuno Vieira <nuno.fcvieira93@gmail.com>
Co-authored-by: Bahadır Öncel <bahadir@getstream.io>
Co-authored-by: Boris Bielik <boris.bielik@getstream.io>
Co-authored-by: Adam Rush <adam@adr-studio.co.uk>
@polqf polqf deleted the release/4.6.0 branch January 12, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants