Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS-2162] Fix message list crash when inserting message in empty list [iOS <15] #2269

Merged
merged 2 commits into from Sep 5, 2022
Merged

[CIS-2162] Fix message list crash when inserting message in empty list [iOS <15] #2269

merged 2 commits into from Sep 5, 2022

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Sep 5, 2022 •
edited

🔗 Issue Links

CIS-2162

🎯 Goal

Fix a crash when inserting a message in an empty message list on iOS Below 15.

It would try to attempt reloading a cell that does not exist, when the message list was empty or with 1 message.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • This change follows zero ⚠️ policy (required)
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Sep 5, 2022
@nuno-vieira nuno-vieira requested a review from a team as a code owner September 5, 2022 10:56
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nuno-vieira nuno-vieira merged commit a7bfa55 into develop Sep 5, 2022
@nuno-vieira nuno-vieira deleted the fix/CIS-2162-Message-List-crash-on-iOS-13-14 branch September 5, 2022 11:59
This was referenced Sep 5, 2022
Closed
Closed
polqf pushed a commit that referenced this pull request Sep 5, 2022
@nuno-vieira @polqf
[CIS-2162] Fix message list crash when inserting message in empty lis…
c3b43fb 
…t [iOS <15] (#2269)

* Fix message list crash when inserting message in empty list [iOS <15]

* Update CHANGELOG.md
@nuno-vieira nuno-vieira mentioned this pull request Sep 6, 2022
Merged
6 tasks
nuno-vieira added a commit that referenced this pull request Sep 6, 2022
@nuno-vieira
[CIS-2162] Fix message list crash when inserting message in empty lis…
1f20286 
…t [iOS <15] (#2269)

* Fix message list crash when inserting message in empty list [iOS <15]

* Update CHANGELOG.md
@nuno-vieira nuno-vieira mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuno-vieira @martinmitrevski